Skip to content

url: tweak default_headers and max_bytes for improved URL titles #1871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dgw merged 1 commit into from
May 25, 2020
Merged

url: tweak default_headers and max_bytes for improved URL titles #1871

dgw merged 1 commit into from
May 25, 2020

Conversation

@cottongin
Copy link
Contributor

@cottongin cottongin commented May 21, 2020

Description

What does this do? What problem does it solve? Does it resolve any GitHub issues?

Adds 'Accept' and 'Accept-Language' headers and spoofs 'User-Agent' while increasing max_bytes so that problematic sites work better for fetching titles

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

dgw
dgw reviewed May 21, 2020
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some ideas for more tweaks as long as you're here.

@dgw dgw added the Tweak label May 21, 2020
@dgw dgw added this to the 7.1.0 milestone May 21, 2020
dgw
dgw approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash it and this goes in the merge queue.

image

@cottongin cottongin force-pushed the tweak-url-patch branch 2 times, most recently from bfff507 to c518143 Compare May 22, 2020 13:40
@dgw dgw changed the title Tweak default_headers for improved URL titles url: tweak default_headers and max_bytes for improved URL titles May 22, 2020
@dgw dgw merged commit eda5e2f into sopel-irc:master May 25, 2020
@cottongin cottongin deleted the tweak-url-patch branch October 2, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Exirel Exirel Exirel left review comments

@dgw dgw dgw approved these changes

Assignees

No one assigned

Labels

Tweak

Projects

None yet

Milestone

7.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@cottongin @dgw @Exirel