Skip to content

ping: add .ping command #1875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dgw merged 1 commit into from
May 29, 2020
Merged

ping: add .ping command #1875

dgw merged 1 commit into from
May 29, 2020

Conversation

@RhinosF1
Copy link
Contributor

@RhinosF1 RhinosF1 commented May 26, 2020 •
edited by dgw
Loading

resolves #1874

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

Exirel
Exirel approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to use reply instead of say, but that's totally optional! It's good as it is.

@RhinosF1 RhinosF1 changed the title Add ping/pong to ping.py ping: add .ping command May 26, 2020
@Exirel Exirel added the Feature label May 26, 2020
@Exirel Exirel added this to the 7.1.0 milestone May 26, 2020
dgw
dgw requested changes May 26, 2020
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this touch sopel/irc/__init__.py? ("Reviewing" as "Request changes" so it won't look ready-to-merge in the list.)

@RhinosF1
Copy link
Contributor Author

RhinosF1 commented May 26, 2020

Why does this touch sopel/irc/__init__.py? ("Reviewing" as "Request changes" so it won't look ready-to-merge in the list.)

because my rebase failed

@RhinosF1
Copy link
Contributor Author

RhinosF1 commented May 28, 2020

Fixed my mess

@Exirel Exirel requested a review from dgw May 28, 2020 08:29
@dgw
Copy link
Member

dgw commented May 28, 2020

@RhinosF1 Your "mess" isn't "fixed" just yet. Need to squash it down again.

@RhinosF1
Copy link
Contributor Author

RhinosF1 commented May 28, 2020

That’ll be fun.

dgw
dgw approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squashed while I'm bored at the tail end of a conference call. Will merge after, assuming checks pass.

@dgw dgw merged commit d7bc97a into sopel-irc:master May 29, 2020
@RhinosF1 RhinosF1 deleted the patch-2 branch November 28, 2020 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgw dgw dgw approved these changes

@Exirel Exirel Exirel approved these changes

Assignees

No one assigned

Labels

Feature

Projects

None yet

Milestone

7.1.0

Development

Successfully merging this pull request may close these issues.

add ping/pong response to ping.py

3 participants

@RhinosF1 @dgw @Exirel