tools.compile_rule: better whitespace handling for $nick placeholder
#1920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exirel
requested changes
Aug 7, 2020
Contributor
Exirel
left a comment
Exirel
left a comment
There was a problem hiding this comment.
OK, that was simple. Didn't expect that to be like that, but I'll take it.
Minor change requested as it explains why there is such a weird if.
If the placeholder is followed by a space, replace it with a pattern that will consume extra whitespace but doesn't require any. If the placeholder is NOT followed by a space, use the original pattern that requires at least one space to match.
dgw
force-pushed
the
rule-nick-placeholder
branch
from
66c306a to
5807799
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the placeholder is followed by a space, replace it with a pattern that will consume extra whitespace but doesn't require any.
If the placeholder is NOT followed by a space, use the original pattern that requires at least one space to match.
Meant to resolve #1885.
Checklist
make qa(runsmake qualityandmake test)