plugin: rename plural decorators to be consistent #1924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `plugin.action_commands` is now `plugin.action_command` * `plugin.commands` is now `plugin.command` * `plugin.nickname_commands` is now `plugin.nickname_command` The legacy imports in `sopel.module` have the old names preserved by using the `as` keyword.
Member
Author
|
(Today I learned that it's possible to minimize browser windows to the system tray by accident. So that was fun.) |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
plugin.action_commandsis nowplugin.action_commandplugin.commandsis nowplugin.commandplugin.nickname_commandsis nowplugin.nickname_commandThe legacy imports in
sopel.modulehave the old names preserved by using theaskeyword.Should be the last thing we need to do for #1619 (except make sure to call out the renames when writing the changelog for 7.1). I did a manual find-and-replace in all files to rename all Sphinx references to these decorators, but the small number of changes it turned up made me suspicious and I'd love a second set of eyes to double-check those. Yes, even though I also went through and reviewed all ~600 matches of "commands" in the source code & doc files.
Checklist
make qa(runsmake qualityandmake test)