-
-
Notifications
You must be signed in to change notification settings - Fork 409
core: change/recover in-use nick; fix obsolete USER command syntax #1930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note that it should fix #300 which is the current oldest issue we have for now. |
dgw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a few nemeseS to slay. Despite a bit of doom and gloom in a couple of my line notes, this seems like a good approach. I'm just a bit mad at shortcomings of the IRC protocol and/or Sopel's threaded/async architecture. 😅
One other thing I couldn't touch in line notes because of GitHub's arbitrary restrictions:
./sopel/irc/__init__.py:49:1: F401 'sopel.tools.events' imported but unused
As discussed with @dgw on IRC, the proper USER command should be: USER <username> 0 * :<real name> I tested on freenode and everything worked fine with that command. Co-authored-by: dgw <[email protected]>
72440f6 to
fe8059c
Compare
dgw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll probably forget to include the USER fix in release notes, but that's what updating PR titles is for. 🤪
Description
Basic implementation to fix #300 (no configuration, no alternative, nothing):
_to its endbot.nickis notbot.settings.core.nick, we try to useNickServ GHOSTbot.settings.core.nickQUIT, we try to get back to that nickMaybe this should be optional, maybe we could have a list of nick aliases to use for that purpose. But I wanted to show what is possible with the current state of the code. It tested it by using a copy of a config file, and checking that the second instance ghost the first one and get its nick back.
From another user point of view, here are the logs:
After some discussions, I also fixed an improper use of the
USERcommand, and made some minor code-style changes.I'll do an Exirel and say: everything else is good for another PR!
Checklist
make qa(runsmake qualityandmake test)