Skip to content

tools: make time and web always accessible by importing tools #1948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dgw merged 1 commit into from
Oct 8, 2020
Merged

tools: make time and web always accessible by importing tools #1948

dgw merged 1 commit into from
Oct 8, 2020

Conversation

@dgw
Copy link
Member

@dgw dgw commented Oct 1, 2020

Description

It's really silly that anyone who wants to use the time submodule has to do import sopel.tools.time even if they've already done from sopel import tools. This makes that unnecessary.

The intention here is to make from sopel import tools the only import needed to use the tools, tools.events, tools.time, and tools.web modules, without any extra nonsense.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@dgw
tools: make time and web always accessible by importing tools
0db69e0 
It's really silly that anyone who wants to use the `time` submodule has
to do `import sopel.tools.time` even if they've already done `from sopel
import tools`. This makes that unnecessary.

The intention here is to make `from sopel import tools` the only import
needed to use the `tools`, `tools.events`, `tools.time`, and `tools.web`
modules, without any extra nonsense.
@dgw dgw added the Tweak label Oct 1, 2020
@dgw dgw added this to the 7.1.0 milestone Oct 1, 2020
@dgw dgw requested a review from a team October 1, 2020 05:01
@dgw dgw mentioned this pull request Oct 1, 2020
Merged
4 tasks
Exirel
Exirel approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 smart

@dgw dgw merged commit 0cd434a into master Oct 8, 2020
@dgw dgw deleted the tools-convenience-imports branch October 8, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Exirel Exirel Exirel approved these changes

Assignees

No one assigned

Labels

Tweak

Projects

None yet

Milestone

7.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@dgw @Exirel