isup: more specific errors #1950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specified timeout values, both to improve response time of the command and to make the connect/read timeout errors relevant. (By default, all we'd get is a generic connection error.) The general `RequestException` is no longer considered as a hard "down". Catching all of the relevant sub-types means something truly strange has to happen in order for none of the `except` clauses to match. Sopel's general exception handling is fine for that, since any occurrences of that should be reported as possible bugs.
Exirel
reviewed
Oct 1, 2020
Exirel
approved these changes
Oct 1, 2020
Contributor
Exirel
left a comment
Exirel
left a comment
There was a problem hiding this comment.
One small nitpick you can fix, but it's good to go.
Exirel
requested changes
Oct 2, 2020
Contributor
Exirel
left a comment
Exirel
left a comment
There was a problem hiding this comment.
Actually, a small nitpick to fix!
4 tasks
|
This pull request introduces 1 alert when merging fc5d5ac into 54e4274 - view on LGTM.com new alerts:
|
Simplifies handler function (flattens the logic a bit).
dgw
force-pushed
the
isup-more-specific-errors
branch
from
fc5d5ac to
0059659
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #1940, wherein @Exirel requested more specific error messages than just "seems down".
Checklist
make qa(runsmake qualityandmake test)