version: tweak docstring for clarification #1952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgw
previously requested changes
Oct 1, 2020
Member
dgw
left a comment
dgw
left a comment
There was a problem hiding this comment.
Being "installed from" git doesn't really make sense.
cottongin
force-pushed
the
tweak-version-docstring
branch
from
1cd4154 to
30bb454
Compare
Co-authored-by: dgw <[email protected]>
dgw
force-pushed
the
tweak-version-docstring
branch
from
30bb454 to
539c733
Compare
dgw
approved these changes
Oct 2, 2020
Member
dgw
left a comment
dgw
left a comment
There was a problem hiding this comment.
I'm just gonna approve this. Don't care if LGTM passes or whatever; it's just a docstring change and easily fixed before merging if something does fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tweak the docstring of the
.versioncommand so it is more accurate and informativeChecklist
make qa(runsmake qualityandmake test)