find_updates: restore unstable release handling #1955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have been using e.g. '7.0.0.rc2', but `_version_info()` parsed such version strings incorrectly as "final". Probably going to stick with some separator, either '.' or '-', between the version number and the release type, so the parsing needs to understand such things.
dgw
added
Tweak
Bugfix
Exirel
approved these changes
Oct 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#1937 cleaned up some unused stuff that should not have been unused. Regardless of how we got here, it's time to put that stuff back in working order.
Coming soon: a companion PR in the website repo to actually generate the right JSON values for this.
Checklist
make qa(runsmake qualityandmake test)Notes
Yes, I meant to leave that last checkbox unchecked. I need to implement the website piece, or at least mock up what the JSON will look like and test on a local dev server. That sounds like a weekend project. 😅