Audit docs (mostly) for incorrect use of the term "module" #1964
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the final step for 7.1 in #1738. Making these commits was literally just me going through about 1,400 find-in-files results for the string "module". Fortunately I was able to skip a lot with negative regex lookarounds (e.g. decorators, object attributes).
I mixed in a few little tweaks to other stuff, because without them it would have been a very small PR indeed.
In summary:
CapReqtype fromirc.utils).cap_req()function provided here. Something to address in a future patch, perhaps.CapReqparamprefix(f8ed9e5)moduleor anything else, yet. I'm still not entirely sure how this andcap_req()fit together, and we'll probably end up dropping most or all of the above commit.get_logger()with deprecation info (e02a286)warning_inparameter fortools.deprecated()in tools: addwarning_inarg to@deprecated; deprecateget_input#1872, but now we won't have to remember to decorate this function later.CapReq.moduleas a@tools.deprecated@property. Looks like nothing was accessing it, but let's still keep it around until 8.0 just in case.Checklist
make qa(runsmake qualityandmake test)ircis rejected)Notes
Yes, I'm aware that I threw some unrelated stuff in here, not that long after admonishing @Exirel for doing the same in #1944. I don't regret it. That stuff needs fixing, too. 😜