Skip to content

tld: Use Wiki API #1970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dgw merged 1 commit into from
Dec 23, 2020
Merged

tld: Use Wiki API #1970

dgw merged 1 commit into from
Dec 23, 2020

Conversation

@half-duplex
Copy link
Member

@half-duplex half-duplex commented Oct 25, 2020 •
edited
Loading

Description

Use the Wikipedia API to fetch only article content instead of scraping the entire page.
I'd like to use a better parser, but we probably don't want to add dependencies to the larger sopel repo just for this.
make qa currently fails in the same way it does on master.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@half-duplex
Copy link
Member Author

half-duplex commented Oct 25, 2020

Ok, I dunno why qa fails on my box, but it passes in CI 🤷

@dgw
Copy link
Member

dgw commented Oct 25, 2020 •
edited
Loading

make qa currently fails in the same way it does on master.

😕

Ok, I dunno why qa fails on my box, but it passes in CI 🤷

Good; I was about to say master doesn't fail anything so WTF 😅
Plus, tld doesn't have any tests (unit, example, or otherwise), so changes to it shouldn't affect the test suite passing anyway.

dgw
dgw requested changes Oct 25, 2020
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tl;dr: except Exception bad

@half-duplex half-duplex requested a review from dgw October 25, 2020 18:43
dgw
dgw reviewed Oct 25, 2020
View reviewed changes
dgw
dgw approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man, I got distracted by the whole Travis CI build queue thing… This is a meaningful reduction in the amount of HTML the bot needs to transfer and parse. Why not?

@dgw dgw added this to the 7.1.0 milestone Oct 27, 2020
@dgw dgw merged commit 92185b6 into sopel-irc:master Dec 23, 2020
@half-duplex half-duplex deleted the tld-wiki-api branch January 17, 2021 22:35
@half-duplex half-duplex restored the tld-wiki-api branch May 14, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgw dgw dgw approved these changes

@Exirel Exirel Exirel approved these changes

Assignees

No one assigned

Labels

Tweak

Projects

None yet

Milestone

7.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@half-duplex @dgw @Exirel