Skip to content

core: quit after SASL Auth failed #1971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dgw merged 2 commits into from
Dec 24, 2020
Merged

core: quit after SASL Auth failed #1971

dgw merged 2 commits into from
Dec 24, 2020

Conversation

@Exirel
Copy link
Contributor

@Exirel Exirel commented Oct 26, 2020 •
edited
Loading

Description

Fix #976 and fix #1780

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@Exirel Exirel added Low Priority Bugfix Generally, PRs that reference (and fix) one or more issue(s) labels Oct 26, 2020
@Exirel Exirel added this to the 7.1.0 milestone Oct 26, 2020
@Exirel Exirel mentioned this pull request Oct 31, 2020
Closed
@Exirel Exirel linked an issue Oct 31, 2020 that may be closed by this pull request
Tries to use capabilities and SASL mechanisms that are not available #1780
Closed
@Exirel
Copy link
Contributor Author

Exirel commented Oct 31, 2020

I updated this PR with new cases, as described in #1780's comments.

dgw
dgw approved these changes Oct 31, 2020
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dgw dgw merged commit 3a81b0c into sopel-irc:master Dec 24, 2020
@Exirel Exirel deleted the core-sasl-fail branch May 1, 2021 17:55
@dgw dgw mentioned this pull request Jun 9, 2021
Open
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgw dgw dgw approved these changes

Assignees

No one assigned

Labels

Bugfix Generally, PRs that reference (and fix) one or more issue(s) Low Priority

Projects

None yet

Milestone

7.1.0

Development

Successfully merging this pull request may close these issues.

Tries to use capabilities and SASL mechanisms that are not available Stuck for 4 minutes after receiving ERR_SASLFAIL

2 participants

@Exirel @dgw