Skip to content

Conversation

@Exirel
Copy link
Contributor

@Exirel Exirel commented Nov 6, 2020

Description

More tests for sopel.tools.time.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@Exirel Exirel added this to the 7.1.0 milestone Nov 6, 2020
@Exirel Exirel requested a review from a team November 6, 2020 23:32
@dgw
Copy link
Member

dgw commented Nov 8, 2020

Needs unused import removed from test_tools.py before I can actually approve. 😅

@Exirel
Copy link
Contributor Author

Exirel commented Nov 8, 2020

What the heck? It passed locally. :|

Maybe I need some update, I'll see to fix that.

Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goodness, how did I forget about this for so long?!

@dgw dgw merged commit 00e8c4d into sopel-irc:master Dec 28, 2020
@Exirel Exirel deleted the tools-test-time branch May 1, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants