instagram: remove "deprecated" (actually removed) oEmbed fallback #1999
Conversation
As reported in #1996, Facebook "deprecated" the oEmbed API endpoint. However, instead of a true deprecation where the endpoint simply starts returning a warning (or even just is marked as deprecated in docs), FB essentially *removed* the endpoint. It no longer returns valid JSON at all, let alone the expected result. Sopel receives plain text stating that the endpoint is "deprecated", with a link for more details. The replacement API endpoint requires an API key, and this seems like a good time to consider removing the Instagram plugin to its own package. I will prepare that change separately, mostly so this fix can be easily cherry-picked into 7.0.x for maintenance, but also because it could be enough to wait for removing the plugin entirely until Sopel 8.0. I'm not personally signed up for Instagram's developer program, so it wouldn't be fair if I alleged that FB never sent a warning before this endpoint stopped working. They might have. I'm just taking issue with the use of the term "deprecated" for something that is *nonfunctional* rather than merely unmaintained or scheduled for removal.
dgw
added
Low Priority
Tweak
Bugfix
|
Does this still work for anyone? Maybe if the bot runs on an innocent residential IP? |
|
I couldn't actually test from my home IP until today, but no dice here either. My local Sopel instance spits out the same Maybe we should just close this, merge #2000, and rebuild the plugin using the key-based API access in its own package? That was always going to be the future, but it looks like this stopgap won't help anything despite what I hoped. |
|
There is a Python library on Github/PyPI which could be the nuts and bolts of a standalone plugin. No developer account needed, works with username and password. |
dgw
added
the
Declined
|
Closing in favor of #2000 and a new standalone plugin package. |
Description
As reported in #1996, Facebook "deprecated" the oEmbed API endpoint. However, instead of a true deprecation where the endpoint simply starts returning a warning (or even just is marked as deprecated in docs), FB essentially removed the endpoint. It no longer returns valid JSON at all, let alone the expected result. Sopel receives plain text stating that the endpoint is "deprecated", with a link for more details.
The replacement API endpoint requires an API key, and this seems like a good time to consider removing the Instagram plugin to its own package. I will prepare that change separately, mostly so this fix can be easily cherry-picked into 7.0.x for maintenance, but also because it could be enough to wait for removing the plugin entirely until Sopel 8.0.
I'm not personally signed up for Instagram's developer program, so it wouldn't be fair if I alleged that FB never sent a warning before this endpoint stopped working. They might have. I'm just taking issue with the use of the term "deprecated" for something that is nonfunctional rather than merely unmaintained or scheduled for removal.
Checklist
make qa(runsmake qualityandmake test)Notes
Requesting review from @kwaaak specifically, as the original plugin author.
@cottongin I'd love a review from you, too, since the fallback logic I'm gutting is from your PR #1911.
I intend to backport this tweak onto 7.0.x, for release as soon as this is merged, since the "Unexpected error" messages described in #1996 are pretty ugly.