Skip to content

Conversation

@Exirel
Copy link
Contributor

@Exirel Exirel commented Dec 14, 2020

Description

Part of #1565 for sopel.plugins.

Most of the changes are missing . and removing initial capital letter in param/return tags.

Then I tried to improve the docstrings for sopel.plugins.handlers, in a somewhat better version.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@Exirel Exirel added this to the 7.1.0 milestone Dec 14, 2020
@Exirel Exirel requested a review from dgw December 14, 2020 15:52
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess I can't just put this as "Comment"; there are too many notes. "Request changes" it is!

Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably ready to squash, since I'm down to nitpicking consistency of word choices. 😹

@Exirel Exirel force-pushed the plugins-docstrings branch from 3dfa8b0 to aaa931b Compare January 14, 2021 16:26
@Exirel
Copy link
Contributor Author

Exirel commented Jan 14, 2021

Squash done.

Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's :shipit:

@dgw dgw merged commit 66ebc5c into sopel-irc:master Jan 17, 2021
@Exirel Exirel deleted the plugins-docstrings branch May 1, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants