remind: .reminders count/forget command #2007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new `reminders` command with subcommands: * `.reminders` will use the `count` subcommand by default * `.reminders count` will count all reminders in the current target (either the current channel or in private messages) * `.reminders forget` will forget all reminders in the current target (either the current channel or in private messages) * using a third argument will limit each action to that target * using `*` (wildcard) as the target will act on all possible targets, i.e. all the channels and in private messages For example `.reminders count *` will give you the sum of all reminders from every channels and every private message for **you** (and you only); and using `.reminders forget` in a private message will make the bot forget about your private reminders only.
dgw
requested changes
Jan 30, 2021
Member
dgw
left a comment
dgw
left a comment
There was a problem hiding this comment.
I do like this idea. Just had a thought about either being "smarter" or giving feedback to the user if they forget the action (e.g. .reminders dgw). Choose your fighter. 😁
Contributor
Author
Got it working, I think. |
dgw
approved these changes
Feb 2, 2021
Member
dgw
left a comment
dgw
left a comment
There was a problem hiding this comment.
I'm not even going to have you squash this. I don't want to wait three hours for Travis to rebuild it. 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #1746
Add a new
reminderscommand with subcommands:.reminderswill use thecountsubcommand by default.reminders countwill count all reminders in the current target (either the current channel or in private messages).reminders forgetwill forget all reminders in the current target (either the current channel or in private messages)*(wildcard) as the target will act on all possible targets, i.e. all the channels and in private messagesFor example
.reminders count *will give you the sum of all reminders from every channels and every private message for you (and you only); and using.reminders forgetin a private message will make the bot forget about your private reminders only.Note: I decided to do something simple, that doesn't try to be too smart, it's not made for admin to reset everything, etc. but I think it's already a good improvement. I wish I had time to rework the plugin (there is a repo for that, I know!), but for now, and for 7.1, that will do.
Also: yay, a Feature PR and not a Bugfix/Documentation/Tweak PR!
Checklist
make qa(runsmake qualityandmake test)