coretasks: update event priorities from high to medium #2018
Conversation
There was a problem hiding this comment.
I might have to go over this again from a computer, after this first review round is addressed, to catch any non-obvious typos that don't jump out at me on GitHub's Android app, but just in general: Why remove the priorities from all those coretasks handlers instead of using "medium", following the Tao of Python's advice that "[e]xplicit is better than implicit"?
|
All fixed! |
dgw
left a comment
dgw
left a comment
There was a problem hiding this comment.
I left coretasks.py itself un-marked as "Viewed" because I'm still curious about removing @plugin.priority from the relevant callables instead of explicitly specifying @plugin.priority('medium'). That's my main concern; the rest of this review is just typos and phrasing tweaks.
I can do that, no problem. |
* events are now at default priority (medium) * events are not threaded anymore * events are now unblockable This will allow other plugin to act before (priority=high) or before (priority=low) the core plugin handles them. One event is still on low priority as it will send a QUIT message.
Co-authored-by: dgw <[email protected]>
Exirel
force-pushed
the
coretasks-event-priority
branch
from
e7d365c to
72bbf01
Compare
|
Done. |
2 participants
Description
Fix #2017 and add a new chapter for advanced tips and tricks.
Checklist
make qa(runsmake qualityandmake test)