Skip to content

url: restore error output when not all .title URLs could be fetched #2029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgw merged 1 commit into from
Mar 23, 2021
Merged

url: restore error output when not all .title URLs could be fetched #2029

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions sopel/modules/url.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,16 +174,30 @@ def title_command(bot, trigger):
else:
urls = [bot.memory['last_seen_url'][trigger.sender]]
else:
urls = web.search_urls(
trigger,
exclusion_char=bot.config.url.exclusion_char)

urls = list( # needs to be a list so len() can be checked later
web.search_urls(
trigger,
exclusion_char=bot.config.url.exclusion_char
)
)

result_count = 0
for url, title, domain, tinyurl in process_urls(bot, trigger, urls):
message = '%s | %s' % (title, domain)
if tinyurl:
message += ' ( %s )' % tinyurl
bot.reply(message)
bot.memory['last_seen_url'][trigger.sender] = url
result_count += 1

expected_count = len(urls)
if result_count < expected_count:
if expected_count == 1:
bot.reply("Sorry, fetching that title failed. Make sure the site is working.")
elif result_count == 0:
bot.reply("Sorry, I couldn't fetch titles for any of those.")
else:
bot.reply("I couldn't get all of the titles, but I fetched what I could!")


@plugin.rule(r'(?u).*(https?://\S+).*')
Expand Down