plugins: rule_lazy, find_lazy, and search_lazy #2037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgw
requested changes
Apr 1, 2021
dgw
approved these changes
Apr 11, 2021
Member
dgw
left a comment
dgw
left a comment
There was a problem hiding this comment.
Good to go. Squash out the fixups and that'll also get rid of the spurious failure ❌ in the PR's commit history. (Despite never being fully set up, AppVeyor was still getting PR notifications, which I believe is now correctly turned off.)
* plugin: add the rule_lazy decorator * loader: properly clean callable with lazy rule loaders * plugins.rules: new `*_lazy` classmethods to handle lazy rules * bot: call `from_callable_lazy` for lazy rules Also, I realized I could do some refactorization of how rule & URL callback are created, as they share more in common than I though. This will be reused later when find_lazy and search_lazy will be added. Note: I know, big commit, not a huge fan either. The next ones should be a bit shorter.
Co-authored-by: dgw <[email protected]>
Co-authored-by: dgw <[email protected]>
Co-authored-by: dgw <[email protected]>
Exirel
force-pushed
the
plugins-more-rule-lazy
branch
from
256e716 to
08d0204
Compare
Contributor
Author
|
Rebased & squashed. |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following the same pattern as url/url_lazy, there is now 3 new decorators:
I saw 3 things:
sopel.plugins.rulesis way too big, a future PR will split that in different files (waiting on rules: fix deprecated usage of tools.compile_rule #2034 to be merged first)Checklist
make qa(runsmake qualityandmake test)