Skip to content

Conversation

@dgw
Copy link
Member

@dgw dgw commented Jun 7, 2021

Description

No issues to reference or anything. Just was pointing someone on IRC to docs that would explain an error they got, and noticed that the docs I was referencing weren't actually quite up-to-date any more.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
    • Didn't bother with tests; no code touched. 😝
  • I have tested the functionality of the things this change touches
    • It doesn't touch code.

Notes

Specifically requesting Exi to review, because he was the last one to touch logging and I want to be sure the revised docs reflect his intentions for the different files (esp. errorfile vs. exceptionfile).

@dgw dgw added this to the 7.1.1 milestone Jun 7, 2021
@dgw dgw requested a review from Exirel June 7, 2021 05:32
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

By suggestion of Exirel, made it a bit more prominent that log files'
names are based on the `basename` of the bot's config, in case plugin
authors might find that tidbit of information useful.
@dgw dgw force-pushed the logging-docs-fix branch from fc65bda to 22ce1a7 Compare June 7, 2021 08:24
@dgw dgw requested a review from Exirel June 7, 2021 08:59
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@dgw dgw merged commit e82f5d0 into master Jun 12, 2021
@dgw dgw deleted the logging-docs-fix branch June 12, 2021 23:28
dgw added a commit that referenced this pull request Jun 12, 2021
Backport of pull request #2090 for 7.1.1 release. Cherry-picked from
original merge commit: e82f5d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants