coretasks: Clear prior modes on RPL_CHANNELMODEIS #2098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
half-duplex
added
the
Bugfix
Exirel
approved these changes
Jun 8, 2021
Contributor
Exirel
left a comment
Exirel
left a comment
There was a problem hiding this comment.
A bit of nitpicking that doesn't prevent approval.
half-duplex
force-pushed
the
rpl-channelmodes-clear
branch
from
92ad9c4 to
26952b3
Compare
half-duplex
force-pushed
the
rpl-channelmodes-clear
branch
from
277ac71 to
8789ae3
Compare
dgw
approved these changes
Jun 11, 2021
Member
dgw
left a comment
dgw
left a comment
There was a problem hiding this comment.
I'm glad that this arrived at a state with reasonable thread-safety, even though I started that conversation for the wrong reason. 😸 Squash away!
half-duplex
force-pushed
the
rpl-channelmodes-clear
branch
from
8789ae3 to
9fdb70a
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RPL_CHANNELMODEIS should contain all channel modes, and we sometimes use
MODE {channel}to sync, so we should discard our old knowledge of the modes when we get the response.Checklist
make qa(runsmake qualityandmake test)