tools.events: convert to Enum
#2127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anyone using these as intended should see no ill effects, but using an `Enum` class will actively thwart plugins that try to do something silly like override a numeric name.
Exirel
approved these changes
Jun 28, 2021
Exirel
approved these changes
Jun 28, 2021
Contributor
Exirel
left a comment
Exirel
left a comment
There was a problem hiding this comment.
Alright, I had second though about the whole str, Enum thing. I'm still not a big fan, but I get it.
dgw
added
the
Breaking Change
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Anyone using these as intended should see no ill effects, but using an
Enumclass will actively thwart plugins that try to do something silly like override a numeric name.Really, it's the same thing as #2122 but for the numeric events instead.
Checklist
make qa(runsmake qualityandmake test)