Skip to content

tools: follow through on all removed_in='8.0' deprecations #2141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dgw merged 1 commit into from
Aug 23, 2021
Merged

tools: follow through on all removed_in='8.0' deprecations #2141

dgw merged 1 commit into from
Aug 23, 2021

Conversation

@dgw
Copy link
Member

@dgw dgw commented Jul 3, 2021

Description

Tin. We aren't going to miss these rule-regex functions (already moved into the relevant plugins.rules types) and convenience stuff from the pre-py3 days.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@dgw dgw added Low Priority Tests Breaking Change Stuff that probably should be mentioned in a migration guide Housekeeping Code cleanup, removal of deprecated stuff, etc. labels Jul 3, 2021
@dgw dgw added this to the 8.0.0 milestone Jul 3, 2021
@dgw dgw requested a review from a team July 3, 2021 06:18
@dgw dgw changed the title tools: follow through on all remove_in='8.0' deprecations tools: follow through on all removed_in='8.0' deprecations Jul 3, 2021
@dgw dgw force-pushed the remove-tools-deprecations branch from c2181be to 65f8b28 Compare July 3, 2021 06:19
@dgw dgw mentioned this pull request Jul 26, 2021
Closed
14 tasks
@dgw dgw linked an issue Jul 26, 2021 that may be closed by this pull request
tools: command-regexp functions shouldn't be public #1887
Closed
14 tasks
@dgw dgw merged commit f76d771 into master Aug 23, 2021
@dgw dgw deleted the remove-tools-deprecations branch August 23, 2021 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Exirel Exirel Exirel approved these changes

Assignees

No one assigned

Labels

Breaking Change Stuff that probably should be mentioned in a migration guide Housekeeping Code cleanup, removal of deprecated stuff, etc. Low Priority Tests

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

tools: command-regexp functions shouldn't be public

3 participants

@dgw @Exirel