Skip to content

Conversation

@dgw
Copy link
Member

@dgw dgw commented Jul 3, 2021

Description

Tin. The "unexpected setting" warning we added in #1973 should alert bot owners if this is still kicking about in their files.

I also unrolled a couple if/else blocks into if-return because… I felt like it.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

Notes

I should probably make a patch for 7.1.x that logs a warning if the language for a channel is loaded from this old setting.

I should probably make a patch for 7.1.x that logs a warning if the
language for a channel is loaded from this old setting.
@dgw dgw added Low Priority Breaking Change Stuff that probably should be mentioned in a migration guide Housekeeping Code cleanup, removal of deprecated stuff, etc. labels Jul 3, 2021
@dgw dgw added this to the 8.0.0 milestone Jul 3, 2021
@dgw dgw requested a review from a team July 3, 2021 06:29
@dgw dgw merged commit 5d9b1c3 into master Aug 24, 2021
@dgw dgw deleted the remove-old-wikipedia-lang branch August 24, 2021 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking Change Stuff that probably should be mentioned in a migration guide Housekeeping Code cleanup, removal of deprecated stuff, etc. Low Priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wikipedia: Use db rather than config to determine default language per channel

3 participants