docs: explicitly select both light and dark Pygments styles #2178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the dark color scheme particularly, the default Pygments style ("native") has some weird choices in places like imports (underlined names), and bland colors.
Having the styles selected explicitly in the docs'
conf.pyalso means we aren't subject to surprise default-value changes from Furo.Notes
I'm not dead set on these choices. They're just the best-looking to me, out of the options I tested (about 60-70% of the available styles) at https://pygments.org/demo/. Got a suggestion that looks better? I'm all eyes.
In particular, I'd love a more colorful style for light mode to match the choice I made in dark mode, but the light-mode styles that do use significant amounts of color are generally quite muted. The few that choose bolder colors come off as garish to me, or even unreadable (light cyan on white, for example—no thanks).
Checklist
make qa(runsmake qualityandmake test)Comparisons
Light mode
Dark mode