Add LGTM config file and explicitly set Python version #2188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For whatever reason, when LGTM extracts code from this project, its interpretConfig tool (a Java JAR, the source for which I can't find) generates an effective config that tells the analysis to use Python 2 despite all of our tooling having been updated to drop that version. It would be nice to get rid of the false positive alerts we have about py2 stuff, so in the absence of any tooling (that I can find) to track down why LGTM infers the wrong Python version... Let's just set it.
Contributor
|
LGTM |
Exirel
approved these changes
Oct 1, 2021
Member
Author
|
Oh, the config change takes effect immediately during the PR build, nice. 3 new alerts, but 12 fixed? I can live with that. |
Contributor
|
🚢 🚢 🚢 🚢 🚢 |
Contributor
|
@dgw maybe you could merge this one first since it touches LGTM and makes it better/faster? |
Member
Author
idk about faster (though that check could hardly be slower 😂), but sure—it is better to run py3 analysis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For whatever reason, when LGTM extracts code from this project, its
interpretConfigtool (a Java JAR, the source for which I can't find) generates an effective config that tells the analysis to use Python 2 despite all of our tooling having been updated to drop it.It would be nice to get rid of the false positive alerts we have about py2 stuff, so in the absence of any tooling (that I can find) to track down why LGTM infers the wrong Python version... Let's just set it.
Checklist
make qa(runsmake qualityandmake test)after merge, I believe. We've seen in the past that e.g. excluding alerts with inline comments won't take effect for PR builds, and the config file probably also behaves that way.