Skip to content

Conversation

@dgw
Copy link
Member

@dgw dgw commented Oct 30, 2021

Description

Fixes #2203 on Python 3.4+ hosts. Anything older, well, we're not going to ship a reimplementation of Python's html.unescape() function (and everything else that actually makes it work) in a patch release when we've already dropped support for those Python versions on master. This bug just isn't a showstopper. It's not worth that.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
    • Well, locally make quality raises E741 on a variable name in sopel/modules/help.py, but that's nothing to do with this patch and it's not going to be an issue on the older version of flake8 configured for use on 7.1.x.
  • I have tested the functionality of the things this change touches

@dgw dgw added the Bugfix Generally, PRs that reference (and fix) one or more issue(s) label Oct 30, 2021
@dgw dgw added this to the 7.1.6 milestone Oct 30, 2021
@dgw dgw requested a review from a team October 30, 2021 06:09
@dgw dgw force-pushed the modernize-web.decode branch from 602f028 to a321946 Compare October 30, 2021 06:15
@dgw dgw merged commit b61f630 into 7.1.x Nov 4, 2021
@dgw dgw deleted the modernize-web.decode branch November 4, 2021 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix Generally, PRs that reference (and fix) one or more issue(s)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants