reddit, test: even more of the comments link format is optional #2216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reddit will accept /r/subreddit/comments/id, /comments/id, or even just /id... The variations never end.
Exirel
requested changes
Dec 1, 2021
Contributor
Exirel
left a comment
Exirel
left a comment
There was a problem hiding this comment.
I like the tests. I just want more.
dgw
force-pushed
the
reddit-bare-comments
branch
from
7a8be4e to
7aeed0c
Compare
Exirel
approved these changes
Dec 6, 2021
dgw
added a commit
that referenced
this pull request
Dec 6, 2021
reddit, test: even more of the comments link format is optional
dgw
added a commit
that referenced
this pull request
Dec 11, 2021
reddit, test: even more of the comments link format is optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reddit will accept
/r/subreddit/comments/id,/comments/id, or even just/id... The variations never end.Follow-up to #2208. After merging I found some further tweaks that hadn't been pushed up yet, probably because of #2210. Could use input from @half-duplex, the person who pointed out these additional URL formats' existence.
While preparing this patch so it wouldn't conflict with the prior merge I noticed that my newly created test file for
redditused Windows line endings, because of course it did (probably a bad editor default on my newer laptop). Review 2bad1e1 on its own for the meaningful changes; 7af3889 contains only whitespace (correcting bad line endings).Checklist
make qa(runsmake qualityandmake test)