-
-
Notifications
You must be signed in to change notification settings - Fork 409
docs: split bot documentation into separate files with minor fix #2226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dgw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one line note from me this time. I don't think there's much else for me to say yet. Excluding the already-merged "time" page, this PR's net line diff is only about +10, I've explicitly not looked at the moved page contents in any detail because I trust (from skimming) that they're nearly identical.
93c7abf to
d1a50ab
Compare
|
I rebased on master so you don't see the other PR's commit in here anymore. I did so after applying your suggestion, which I kept in a separate commit. Nothing else has change since your last review. |
dgw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I am with more thoughts. This is certainly not the end of bikeshedding. 🙀
|
@dgw I changed the wording for join/part, and I'm now tempted to write a guideline about time (the thing we discussed on IRC when playing with timeformat) in that PR, if that's cool with you. |
dgw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In other news, I'm thinking (again) about a :pypi: custom Sphinx role…
|
Like I said on IRC, I realized that the conflict is more annoying than risky. However, given it's a doc PR, I don't want to rebase & squash before @dgw agree to, otherwise he'll complain about tracking changes. 😁 |
dgw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw one more nit, but you can apply it (or not) during the squash. I'm not going to spend the time post-squash checking to make sure you actually used it. 😛
Co-authored-by: dgw <[email protected]>
Co-authored-by: dgw <[email protected]>
Co-authored-by: dgw <[email protected]>
7407d35 to
30d7015
Compare
|
Applied, squashed & done. |

Description
More than the title:
bot/talk.rst(dgw you need to check that, the text is short enough so it shouldn't be too painful)Checklist
make qa(runsmake qualityandmake test)