tools: deprecate more Python 2-like shims #2228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These four functions were for backward compatibility, as they all stand in for features removed in Python 3. Sopel no longer supports Python 2, and it's long past time for plugin authors to use the correct Python 3 functions instead of these. Honestly, no one should be using these any more in almost-2022. Think of the deprecation warning(s) as a wake-up call to modernize your code!
Sphinx will include the `iter*` members in output because they are just aliases to built-in functions that have docstrings. Not strictly necessary for `raw_input`, but it's better to be explicit.
dgw
force-pushed
the
tools-deprecations
branch
from
9ad2722 to
c0ec264
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These four functions were for backward compatibility, as they all stand in for features removed in Python 3. Sopel no longer supports Python 2, and it's long past time for plugin authors to use the correct Python 3 functions instead of these.
Honestly, no one should be using these any more in almost-2022. Think of the deprecation warning(s) as a wake-up call to modernize your code!
Checklist
make qa(runsmake qualityandmake test)Notes
Excluded the now-deprecated module members from coverage reporting, in an attempt to keep our coverage percentage focused only on code we intend to keep. Also excluded these members from the docs. Compare deploy preview to current unstable.