translate: update langcode() helper to support Chinese
#2242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a semi-temporary fix for #2241. It's still not perfect (still allows using unsupported or nonexistent language codes), but there will be additional options available in Sopel 8.0 and beyond. Goal for this is to avoid adding any new dependencies in 7.1.x.
dgw
added
the
Bugfix
dgw
force-pushed
the
translate-zh-flags
branch
from
c84ebfb to
037bb32
Compare
Exirel
approved these changes
Jan 23, 2022
Contributor
Exirel
left a comment
Exirel
left a comment
There was a problem hiding this comment.
Just a nitpick, doesn't prevent approval.
dgw
added a commit
that referenced
this pull request
Feb 6, 2022
translate: update `langcode()` helper to support Chinese
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a semi-temporary fix for #2241. It's still not perfect (still allows using unsupported or nonexistent language codes), but there will be additional options available in Sopel 8.0 and beyond. Goal for this is to avoid adding any new dependencies in 7.1.x.
Checklist
make qa(runsmake qualityandmake test)