Skip to content

loader, rules: use (pre)trigger.ctcp instead of tags #2253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dgw merged 4 commits into from
Jun 1, 2022
Merged

loader, rules: use (pre)trigger.ctcp instead of tags #2253

dgw merged 4 commits into from
Jun 1, 2022

Conversation

@Exirel
Copy link
Contributor

@Exirel Exirel commented Feb 10, 2022 •
edited
Loading

Description

Sopel 8's steps of #1683:

  • replace trigger.tags['intent'] by trigger.ctcp (same for PreTrigger)
  • replace plugin_callable.intents by plugin_callable.ctcp
  • replace AbstractRule.match_intent by AbstractRule.match_ctcp
  • update tests and documentation accordingly
  • add various type hint

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@Exirel Exirel added this to the 8.0.0 milestone Feb 10, 2022
@dgw dgw mentioned this pull request Feb 11, 2022
Open
6 tasks
dgw
dgw reviewed Feb 11, 2022
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've taken a look, marked a few minor things, and updated the task list in #1683. Will also mark this PR as a draft right after submitting the review, since you said on IRC that you meant to open it in the draft state.

@dgw dgw marked this pull request as draft February 11, 2022 03:59
@Exirel Exirel force-pushed the plugins-rules-match-ctcp branch from 02617bf to 5aeec51 Compare May 27, 2022 21:37
@Exirel Exirel marked this pull request as ready for review May 27, 2022 21:37
@Exirel
Copy link
Contributor Author

Exirel commented May 27, 2022

This PR was seriously outdated, and I wanted to be sure that was not going to add documentation that would conflict with anything new.

As a result, the doc looks pretty nice with the latest Furo update.

dgw
dgw approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything I missed beyond this point will just have to become a "#2253 broke it" comment in some later issue/patch.

@dgw dgw merged commit 3a5ba8e into sopel-irc:master Jun 1, 2022
@Exirel Exirel deleted the plugins-rules-match-ctcp branch June 12, 2022 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgw dgw dgw approved these changes

Assignees

No one assigned

Labels

Core/IRC Protocol Handling Core/Plugin Handling

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Exirel @dgw