Skip to content

Conversation

@SnoopJ
Copy link
Contributor

@SnoopJ SnoopJ commented May 26, 2022

Description

This PR coalesces repeated whitespace in MediaWiki excerpts (#2259)

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
    • NOTE: I do see 9 test failures, 72 errors, but this is the same result against the current HEAD (984e1b9)
  • I have tested the functionality of the things this change touches

@dgw dgw added Low Priority Bugfix Generally, PRs that reference (and fix) one or more issue(s) labels May 26, 2022
@dgw dgw added this to the 8.0.0 milestone May 26, 2022
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already approved by multiple devs in #2259 discussion and on IRC.

  • NOTE: I do see 9 test failures, 72 errors, but this is the same result against the current HEAD (984e1b9)

You didn't specify anything about your dev environment, but it sounds like some things are probably missing. My local copy of HEAD passes all tests, and this patch passed in CI.

@SnoopJ
Copy link
Contributor Author

SnoopJ commented May 26, 2022

Yep, goofed up and didn't pay attention to the dev requirements. Passing now with the stuff I was missing.

@dgw dgw merged commit 36b7c2f into sopel-irc:master May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix Generally, PRs that reference (and fix) one or more issue(s) Low Priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants