Skip to content

Conversation

@SnoopJ
Copy link
Contributor

@SnoopJ SnoopJ commented Jun 8, 2022

Description

This PR corrects the warning message emitted by Sopel when running on Python prior to 3.8 to give the correct EOL for CPython 3.7

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@half-duplex half-duplex added this to the 8.0.0 milestone Jun 8, 2022
@half-duplex half-duplex changed the title Cite correct EOL date for Python 3.7 in emitted warnings Remove Python EOL warnings Jun 8, 2022
@SnoopJ SnoopJ force-pushed the update-warning-text branch from 3b6c9e5 to da67b6a Compare June 8, 2022 17:26
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I obviously approve for the reasons given on IRC, lol.

Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That feels good.

@dgw dgw merged commit e38942e into sopel-irc:master Jun 8, 2022
@dgw dgw added the Housekeeping Code cleanup, removal of deprecated stuff, etc. label Jun 8, 2022
@SnoopJ SnoopJ deleted the update-warning-text branch June 8, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Housekeeping Code cleanup, removal of deprecated stuff, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants