sopel: fix TODOs related to Python 2 #2326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't solve issues with reload. Sorry.
Exirel
added
Breaking Change
dgw
reviewed
Jul 24, 2022
Member
dgw
left a comment
dgw
left a comment
There was a problem hiding this comment.
Not a very big diff considering that scary comment about moving plugin loading to importlib being non-trivial. How well-tested is this?
Contributor
Author
Pretty well, if you look at coverage. https://coveralls.io/builds/50929691/source?filename=sopel%2Fplugins%2Fhandlers.py#L417 I spent some time making sure it worked and that there was tests. |
Member
|
You've tried it "live" in addition to running the test suite? (Just being specific, for documentation reasons.) |
dgw
approved these changes
Aug 3, 2022
Member
dgw
left a comment
dgw
left a comment
There was a problem hiding this comment.
Barring Ex stating explicitly that he's tried this patch live, I'll just merge it into a test branch on our Official™ instance at Libera and see if any of the external plugins there explode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tin. Fix parts of #2120 related to Python 2.
Checklist
make qa(runsmake qualityandmake test)