loader, plugin: remove deprecated features #2329
Merged
+74
−116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exirel
added
the
Breaking Change
dgw
reviewed
Jul 24, 2022
Member
dgw
left a comment
dgw
left a comment
There was a problem hiding this comment.
Even trying to minimize line notes, I still ended up with double digits. x)
Contributor
Author
|
All done for me. One last call to make for you. |
dgw
reviewed
Aug 7, 2022
Member
dgw
left a comment
dgw
left a comment
There was a problem hiding this comment.
It's hard to look over everything again on mobile, but I found one place where a wording tweak that was meant to be copied over from another line note once we settled on something, hadn't been.
Also gave my final opinion on the re.escape() wrapper. 😁
Contributor
Author
|
Gone is |
dgw
approved these changes
Aug 12, 2022
Member
dgw
left a comment
dgw
left a comment
There was a problem hiding this comment.
Squishy time. 🚀
Any uncaught grammar/style issues in the rewritten docs are now my fault, for failing to catch them even after 3 weeks of reviews. 😁
Co-authored-by: dgw <[email protected]>
Exirel
force-pushed
the
todo-remove-in-sopel8
branch
from
d88b6a1 to
06add14
Compare
Contributor
Author
|
Squashed. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tin. Part of #2120:
I didn't touch the currency plugin, will do in another PR.
Checklist
make qa(runsmake qualityandmake test)