currency: fiat_provider config option takes precedence #2330
+28
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exirel
added
Breaking Change
dgw
approved these changes
Jul 24, 2022
Member
dgw
left a comment
dgw
left a comment
There was a problem hiding this comment.
I'm nitpicking. There's nothing actually "wrong" with the patch; it just took a bit more mental energy to review than it would have otherwise due to extraneous code style changes. :P
Contributor
Author
|
And done. |
dgw
approved these changes
Aug 7, 2022
Member
dgw
left a comment
dgw
left a comment
There was a problem hiding this comment.
Nitpick resolved, I see. Squash away 🚀
Exirel
force-pushed
the
currency-fiat-provider-precedence
branch
from
cb9bac0 to
e9e090d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tin, part of #2120.
Checklist
make qa(runsmake qualityandmake test)