db: fix typing.cast according to flake8-type-checking #2335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exirel
added
High Priority
Bugfix
Member
|
Huh, nice work getting to this before I could. Am I missing a cleaner way to do this, bypassing the overhead of a call to |
dgw
approved these changes
Jul 30, 2022
Member
dgw
left a comment
dgw
left a comment
There was a problem hiding this comment.
Tbh I should have made my previous comment in the form of an approving review, because it's just idle thought. Silly dgw.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tin. Issue introduced by the new flake8-type-checking feature in recent release.
Checklist
make qa(runsmake qualityandmake test)