irc: LINELEN ISUPPORT token support/use
#2346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take advantage of the (possibly niche) LINELEN token in 005 to send longer messages than the RFC limit of 512 bytes, when possible. Can't say I've ever seen a network actually advertise this token, but it's relatively easy to add and test so why not support it.
Exirel
approved these changes
Sep 2, 2022
Contributor
Exirel
left a comment
Exirel
left a comment
There was a problem hiding this comment.
Looks straightforward to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take advantage of the
LINELENtoken in 005 to send longer messages than the RFC limit of 512 bytes, when possible.Can't say I've ever seen a network actually advertise this token, but it's relatively easy to add and test so why not support it.
Checklist
make qa(runsmake qualityandmake test)Notes
This was previously flagged as obsolete, but InspIRCd still uses it (refs: ircdocs/irc-defs#82, https://github.com/inspircd/inspircd/blob/e147b461173c58eb443eee0ac56f7d3c3c4b2c3a/src/server.cpp#L218).
Docs link in the code points to a nonexistent section at time of writing. See ircdocs/modern-irc#189 for the patch that will add it.