trigger: make text empty if args is empty, per docs
#2360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An IRC command/event such as 'AWAY' with no message, or 'PING', will have an empty `args` list. Documentation for the (Pre)Trigger `text` attribute says that it will contain the last item in `args` if the line does not contain ':', but it previously contained the command name in such cases.
dgw
added
Bugfix
Exirel
approved these changes
Oct 13, 2022
4 tasks
Member
Author
|
(I just pushed to the wrong branch, but that's OK. It'll be something I can force-push after #2359 gets merged, to make GH realize what is actually part of the PR.) |
dgw
force-pushed
the
trigger.text-empty-args
branch
from
c6da926 to
93c2e88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An IRC command/event such as 'AWAY' with no message, or 'PING', will have an empty
argslist.Documentation for the (Pre)Trigger
textattribute says that it will contain the last item inargsif the line does not contain ':', but it previously—erroneously—contained the command name in such cases.Checklist
make qa(runsmake qualityandmake test)Notes
Starting this as a draft because it's built on top of #2359. Whether I separate the histories or not, I'll have to faff with something after merging one before the other can be merged. Would rather have the simplest rebase imaginable (which this strategy will get me) than a rebase that requires the interactive mode.
Same as the parent PR, 'Breaking Change' label because fixing this after so long could cause a spacebar heating incident.