unicode_info: ignore type check on unicodedata2 #2361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exirel
added
Bugfix
dgw
reviewed
Oct 14, 2022
dgw
added
Tests
and removed
Bugfix
dgw
approved these changes
Oct 14, 2022
Member
dgw
left a comment
dgw
left a comment
There was a problem hiding this comment.
Poor GHA will have to run CI a third time for these changes when you squash, but oh well. Can't [skip ci] on the final, merge-ready state of a PR because of our required checks. 😁
Member
|
@Exirel ping for squash |
* ignore import error because unicodedata2 doesn't have a stub * ignore no-redef error because unicodedata2 is optional and it has the same interface as unicodedata Also modified some comments because nitpicking is my pride. Co-authored-by: dgw <[email protected]>
Exirel
force-pushed
the
unicode-info-ignore-type-check
branch
from
6cdbe4d to
c728d52
Compare
Contributor
Author
|
I DID IT. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
unicodedata2doesn't have a stubunicodedata2is optional and it has the same interface asunicodedataAlso modified some comments because nitpicking is my pride.
Checklist
make qa(runsmake qualityandmake test)