Skip to content

backends: fix event loop close on invalid utf8 rx #2369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dgw merged 1 commit into from
Nov 1, 2022
Merged

backends: fix event loop close on invalid utf8 rx #2369

dgw merged 1 commit into from
Nov 1, 2022

Conversation

@half-duplex
Copy link
Member

@half-duplex half-duplex commented Oct 31, 2022

Description

Upon receiving a line that isn't valid unicode, decode_line raises an exception which isn't caught and kills the event loop.

I broke this in #2365 by confusing what class I was in and which contained .isupport, and trusting the (also by me, also incorrect) unit tests... Sorry >.>

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches (including on a live server sending invalid unicode this time)

@half-duplex half-duplex added High Priority Bugfix Generally, PRs that reference (and fix) one or more issue(s) Core/IRC Protocol Handling labels Oct 31, 2022
@half-duplex half-duplex added this to the 8.0.0 milestone Oct 31, 2022
dgw
dgw reviewed Oct 31, 2022
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test case to make sure that the backend.utf8only flag is set properly from incoming 005?

@half-duplex half-duplex requested a review from dgw October 31, 2022 23:33
dgw
dgw approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dgw dgw merged commit 2f50dbe into sopel-irc:master Nov 1, 2022
@half-duplex half-duplex deleted the utf8only-fix branch November 1, 2022 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgw dgw dgw approved these changes

Assignees

No one assigned

Labels

Bugfix Generally, PRs that reference (and fix) one or more issue(s) Core/IRC Protocol Handling High Priority

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@half-duplex @dgw