-
-
Notifications
You must be signed in to change notification settings - Fork 409
trigger, irc: use STATUSMSG to handle status specific messages in channels #2370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dgw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this version of the patch complies with the STATUSMSG spec. See line notes.
Don't worry, there are also some of the usual doc/comment nitpicks. 😜
dgw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's squash time. Might be spaghetti squash, but time will tell us that. 🙃
da4d18b to
d3fb9ac
Compare
Co-authored-by: dgw <[email protected]>
Co-authored-by: dgw <[email protected]>
d3fb9ac to
08ed2e6
Compare
|
Squashed! |
Description
Fix #1886.
In this PR, I modified
PreTriggerto parse thesenderto check if the prefix was aSTATUSMSGprefix, i.e. a message intended to a specific privilege level in the channel (such as ops, voice, etc.). Once this is done, thePreTriggerremove that prefix from thesenderto create an instance ofIdentifier. On the bot's side, every time aPreTriggeris instantiated,bot.isupport.get('STATUSMSG')is provided.I added some tests to show how that works and ensure it works as intended without breaking anything, so we should be all good.
Two notes to consider for the future:
STATUSMSGvalue, or have something a bit smarter about thatBoth to be considered later, not in this PR.
Checklist
make qa(runsmake qualityandmake test)