CodeQL minor nitpick pass

sopel/config/types.py

@@ -101,8 +101,10 @@ def configure_setting(self, name, prompt, default=NO_DEFAULT):
         attribute = getattr(self.__class__, name)
         if default is NO_DEFAULT and not attribute.is_secret:
             try:
+                # get current value of this setting to use as prompt default
                 default = getattr(self, name)
             except AttributeError:
+                # there is no current value; that's OK
                 pass
             except ValueError:
                 print('The configured value for this option was invalid.')

sopel/formatting.py

@@ -23,6 +23,9 @@
     'CONTROL_STRIKETHROUGH',
     'CONTROL_MONOSPACE',
     'CONTROL_REVERSE',
+    # convenience lists
+    'CONTROL_FORMATTING',
+    'CONTROL_NON_PRINTING',
     # utility functions
     'color',
     'hex_color',

sopel/tools/__init__.py

@@ -32,10 +32,6 @@
 from . import time, web  # NOQA
 
 
-# Can be implementation-dependent
-_regex_type = type(re.compile(''))
-
-
 # Long kept for Python compatibility, but it's time we let these go.
 raw_input = deprecated(  # pragma: no cover
     'Use the `input` function directly.',

sopel/tools/memories.py

@@ -8,11 +8,11 @@
 
 from collections import defaultdict
 import threading
-import typing
+from typing import TYPE_CHECKING
 
 from .identifiers import Identifier
 
-if typing.TYPE_CHECKING:
+if TYPE_CHECKING:
     from typing import Callable, Optional
 
     IdentifierFactory = Callable[[str], Identifier]