bot, ip: fix minor type issues #2393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgw
reviewed
Jan 4, 2023
dgw
approved these changes
Jan 4, 2023
Member
dgw
left a comment
dgw
left a comment
There was a problem hiding this comment.
And this time I will wait for you to squash, unlike the last merge. 🙊
In a previous version, Sopel was not guarantee to have the retrieve function, that may come from different imports based on the Python version. Now that everything is running with Python 3+, the function always exists, so `elif retrieve:` was always true, becoming an irrelevant condition. `mypy` complained, rightfully so, about it. Co-authored-by: dgw <[email protected]>
Exirel
force-pushed
the
mypy-type-fix-bot-and-ip
branch
from
f141f28 to
7f07a95
Compare
Contributor
Author
|
Done, ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After upgrading mypy, I discovered two small problems to fix:
Optionalfor an optional argument insopel.botipbuilt-in pluginNote about the
ipplugin: I didn't change the code or its formatting beside removing the unnecessaryelif/elseand removing one level of indentation. So if anything is wrong in this block of code, sorry I didn't check.Checklist
make qa(runsmake qualityandmake test)