Skip to content

cli.run: remove obsolete --quiet arg #2404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgw merged 1 commit into from
Feb 14, 2023
Merged

cli.run: remove obsolete --quiet arg #2404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions sopel/cli/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,11 +127,6 @@ def build_parser():
'background. The instance will be named after the name of the '
'configuration file used to run it. '
'To stop it, use ``sopel stop`` (with the same configuration).')
parser_start.add_argument(
'--quiet',
action="store_true",
dest="quiet",
help="Suppress all output")
utils.add_common_arguments(parser_start)

# manage `configure` subcommand
Expand Down Expand Up @@ -166,23 +161,13 @@ def build_parser():
action='store_true',
default=False,
help='Kill Sopel without a graceful quit')
parser_stop.add_argument(
'--quiet',
action="store_true",
dest="quiet",
help="Suppress all output")
utils.add_common_arguments(parser_stop)

# manage `restart` subcommand
parser_restart = subparsers.add_parser(
'restart',
description='Restart a running Sopel instance',
help='Restart a running Sopel instance')
parser_restart.add_argument(
'--quiet',
action="store_true",
dest="quiet",
help="Suppress all output")
utils.add_common_arguments(parser_restart)

return parser
Expand Down
27 changes: 0 additions & 27 deletions test/cli/test_cli_run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,10 @@ def test_build_parser_start():
assert hasattr(options, 'config')
assert hasattr(options, 'configdir')
assert hasattr(options, 'daemonize')
assert hasattr(options, 'quiet')

assert options.config == 'default'
assert options.configdir == config.DEFAULT_HOMEDIR
assert options.daemonize is False
assert options.quiet is False


def test_build_parser_start_config():
Expand Down Expand Up @@ -97,13 +95,6 @@ def test_build_parser_start_daemonize():
assert options.daemonize is True


def test_build_parser_start_quiet():
parser = build_parser()

options = parser.parse_args(['start', '--quiet'])
assert options.quiet is True


def test_build_parser_stop():
"""Assert parser's namespace exposes stop's options (default values)"""
parser = build_parser()
Expand All @@ -113,12 +104,10 @@ def test_build_parser_stop():
assert hasattr(options, 'config')
assert hasattr(options, 'configdir')
assert hasattr(options, 'kill')
assert hasattr(options, 'quiet')

assert options.config == 'default'
assert options.configdir == config.DEFAULT_HOMEDIR
assert options.kill is False
assert options.quiet is False


def test_build_parser_stop_config():
Expand Down Expand Up @@ -148,13 +137,6 @@ def test_build_parser_stop_kill():
assert options.kill is True


def test_build_parser_stop_quiet():
parser = build_parser()

options = parser.parse_args(['stop', '--quiet'])
assert options.quiet is True


def test_build_parser_restart():
"""Assert parser's namespace exposes restart's options (default values)"""
parser = build_parser()
Expand All @@ -163,11 +145,9 @@ def test_build_parser_restart():
assert isinstance(options, argparse.Namespace)
assert hasattr(options, 'config')
assert hasattr(options, 'configdir')
assert hasattr(options, 'quiet')

assert options.config == 'default'
assert options.configdir == config.DEFAULT_HOMEDIR
assert options.quiet is False


def test_build_parser_restart_config():
Expand All @@ -187,13 +167,6 @@ def test_build_parser_restart_configdir():
assert options.configdir == 'custom'


def test_build_parser_restart_quiet():
parser = build_parser()

options = parser.parse_args(['restart', '--quiet'])
assert options.quiet is True


def test_build_parser_configure():
"""Assert parser's namespace exposes configure's options (default values)"""
parser = build_parser()
Expand Down