logger: use newer, more robust IRC connection check #2410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The revamped `connection_registered` bot property checks for a backend, a socket connection, AND connection registration. This is what we need to prevent doing a `say()` before the IRC connection is ready.
Exirel
approved these changes
Feb 12, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The revamped
connection_registeredbot property checks for a backend, a socket connection, AND connection registration. This is what we need to prevent doing asay()before the IRC connection is ready.This might be a fix for #2255, but I haven't tested for that specific case yet. Regardless, this old-style check is due for replacement.
Checklist
make qa(runsmake qualityandmake test)