Skip to content

Conversation

@dgw
Copy link
Member

@dgw dgw commented Feb 28, 2023

Description

Sopel's not designed to run directly from a Git working directory any more, so let's not advertise this command that relies upon it.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches
    • It was really easy to test, because this only removes stuff.

@dgw dgw added Breaking Change Stuff that probably should be mentioned in a migration guide Housekeeping Code cleanup, removal of deprecated stuff, etc. labels Feb 28, 2023
@dgw dgw added this to the 8.0.0 milestone Feb 28, 2023
@dgw dgw requested a review from a team February 28, 2023 17:35
Sopel's not designed to run directly from a Git working directory any
more, so let's not advertise this command that relies upon it.
@dgw dgw force-pushed the reload-rm-update-cmd branch from 8b293ea to c743925 Compare February 28, 2023 17:40
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍 😍 😍 😍

@dgw
Copy link
Member Author

dgw commented Mar 3, 2023

(How dumb do you have to be to click "close" instead of "merge"? At least as dumb as me, I guess.)

@dgw dgw merged commit 10bc3ed into master Mar 3, 2023
@dgw dgw deleted the reload-rm-update-cmd branch March 3, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking Change Stuff that probably should be mentioned in a migration guide Housekeeping Code cleanup, removal of deprecated stuff, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants