tools.time: tweaks & tests #2446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exirel
added
Tests
Bugfix
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dgw
reviewed
Apr 24, 2023
Contributor
Author
|
Did all the change as requested, ready for another review. |
dgw
reviewed
May 24, 2023
Member
dgw
left a comment
dgw
left a comment
There was a problem hiding this comment.
Couple ideas… My procrastination on $work stuff is your gain!
SnoopJ
reviewed
May 24, 2023
Co-authored-by: dgw <[email protected]>
Co-authored-by: James Gerity <[email protected]>
Exirel
force-pushed
the
test-coverage-tool-time
branch
from
549d9fc to
7b9445f
Compare
Contributor
Author
|
I squashed the fix commit on the parent's commit, so you shouldn't have issue with changes from master! |
dgw
added
the
Breaking Change
SnoopJ
approved these changes
May 30, 2023
Contributor
SnoopJ
left a comment
SnoopJ
left a comment
There was a problem hiding this comment.
I have no more remarks for this, LGTM
dgw
approved these changes
May 30, 2023
Member
dgw
left a comment
dgw
left a comment
There was a problem hiding this comment.
I'll make CliffsNotes on behavior changes to mention in the changelog by editing the OP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evolved description
validate_timezone()raisesValueErroreven if passedNonenow, instead of returningNoneseconds_to_split()functionOriginal description
Tin. Oh, and also I added type annotations and fixed the resulting type errors.
I ensure that the tests all pass on the current version of
sopel.tools.time, then I added type annotations, so there is a guarantee that it works pretty much as it did before... except for a bug I fixed where you could call a function without adband it would raise anAttributeErrorbecauseNoneTypedoesn't have the right method.Checklist
make qa(runsmake qualityandmake test)