Replace uses of deprecated datetime.utcnow()
#2468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgw
added
Tweak
Documentation
Housekeeping
dgw
changed the title
datetime.utcnow()
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As @SnoopJ mentioned on IRC right after opening #2457,
datetime.utcnow()is deprecated in Python 3.12 (and alsodatetime.utcfromtimestamp()). The recommended replacements for those items have been usable for most of Python 3's history—though we don't get to usedatetime.UTCinstead ofdatetime.timezone.utcuntil Python 3.11 is our minimum version.Checklist
make qa(runsmake qualityandmake test)Notes
As often happens when I poke at stuff, there are some minor documentation corrections lumped in here that I didn't think warranted (a) separate PR(s).
I wanted to go further with this and get rid of
pytz, butzoneinfoisn't available until Python 3.9. (There is abackports.zoneinfopackage, but it hasn't been updated in a while and its issue tracker is starting to fill with reports of errors & warnings.)